Fix position of $enableXsdValidation in DoctrineOrmMappingsPass::createXmlMappingDriver#2190
Merged
ostrolucky merged 6 commits intodoctrine:3.2.xfrom Dec 24, 2025
Merged
Conversation
KDederichs
force-pushed
the
fix/2189
branch
3 times, most recently
from
273a0c0 to
60fca85
Compare
GromNaN
changed the title
$enableXsdValidation in DoctrineOrmMappingsPass::createXmlMappingDriver
GromNaN
reviewed
Dec 23, 2025
KDederichs
force-pushed
the
fix/2189
branch
2 times, most recently
from
d477787 to
ef89b36
Compare
Fix by allowing $enableXsdValidation to contain an array. If it does trigger a deprecation and grab the correct $enableXsdValidation parameter via func_get_arg
Fix by allowing $enableXsdValidation to contain an array. If it does trigger a deprecation and grab the correct $enableXsdValidation parameter via func_get_arg
GromNaN
approved these changes
Dec 23, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes the parameter order issue in DoctrineOrmMappingsPass::createXmlMappingDriver by handling the deprecated $aliasMap parameter that was previously in the 4th position. The fix maintains backward compatibility while deprecating the old signature.
Key Changes
- Added deprecation handling for the old method signature where
$aliasMapwas the 4th parameter - Modified the
$enableXsdValidationparameter to acceptbool|arrayto detect old usage - Properly extracts the intended
$enableXsdValidationvalue when the deprecated signature is used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greg0ire
reviewed
Dec 23, 2025
Co-authored-by: Grégoire Paris <[email protected]>
Co-authored-by: Copilot <[email protected]>
greg0ire
reviewed
Dec 23, 2025
greg0ire
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix by allowing $enableXsdValidation to contain an array. If it does trigger a deprecation and grab the correct $enableXsdValidation parameter via func_get_arg
Fixes #2189