Skip to content

Ability to set a custom page title via _sidebar.md #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QingWei-Li merged 2 commits into from
Jun 29, 2018
Merged

Ability to set a custom page title via _sidebar.md #557

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db4e16
Ability to set a custom page title via _sidebar.md
Jun 28, 2018
ffa9374
fixes after review
Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/event/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ export function getAndActive(router, el, isParent, autoTitle) {
})

if (autoTitle) {
dom.$.title = target ? `${target.innerText} - ${title}` : title
if(target && target.title){
dom.$.title = target.title
}else{
dom.$.title = target ? `${target.innerText} - ${title}` : title
}
Copy link
Member

@QingWei-Li QingWei-Li Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

dom.$.title = target ? (target.title || `${target.innerText} - ${title}`) : title

This performance is better.

Copy link
Contributor Author

@soulfly soulfly Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}

return target
Expand Down