Skip to content

fix: sidebar title error #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-records merged 2 commits into from
Aug 26, 2020
Merged

fix: sidebar title error #1360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e124c0b
fix: sidebar title error
sy-records Aug 26, 2020
45bd355
Update sidebar.js
sy-records Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/core/event/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function getAndActive(router, el, isParent, autoTitle) {
const href = a.getAttribute('href');
const node = isParent ? a.parentNode : a;

a.title = a.innerText;
a.title = a.title || a.innerText;

if (hash.indexOf(href) === 0 && !target) {
target = a;
Expand All @@ -95,7 +95,6 @@ export function getAndActive(router, el, isParent, autoTitle) {
dom.toggleClass(node, 'remove', 'active');
}
});

if (autoTitle) {
dom.$.title = target
? target.title || `${target.innerText} - ${title}`
Expand Down