Add server search feature to workingsets #211
Merged
+1,948
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to search across all working sets to return a list of servers grouped by working set id.
cmrigney
approved these changes
Oct 31, 2025
Comment on lines
+143
to
+149
| WHERE ($1 = '' OR id = $1) | ||
| AND ($2 = '' OR EXISTS ( | ||
| SELECT 1 | ||
| FROM json_each(servers) | ||
| WHERE LOWER(json_extract(value, '$.image')) LIKE '%' || LOWER($2) || '%' | ||
| OR LOWER(json_extract(value, '$.source')) LIKE '%' || LOWER($2) || '%' | ||
| )) |
pkg/workingset/search.go
Outdated
| Servers []Server `json:"servers" yaml:"servers"` | ||
| } | ||
|
|
||
| func Search(ctx context.Context, dao db.DAO, query string, workingSetID string, format OutputFormat) error { |
There was a problem hiding this comment.
nitpick: In case we ever add a docker mcp workingset search, maybe we should rename this to SearchServers?
There was a problem hiding this comment.
I think me naming it Search here breaks convention of keeping it the same name as the command. I'll rename to Servers and will free up Search
| } | ||
| } | ||
|
|
||
| formatting.PrettyPrintTable(rows, []int{40, 10, 120}) |
There was a problem hiding this comment.
Oh, I should use this on the other human readable prints. Didn't realize we had it!
There was a problem hiding this comment.
We should probably factor it out. It is coming from
github.com/docker/mcp-gateway/cmd/docker-mcp/secret-management/formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add ability to search across all working sets to return a list of servers grouped by working set id.
For example
docker mcp workingset servers --filter test --workingset test-setWould return