tlsconfig: Remove support for encrypted TLS private keys #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
remove_encrypted_key_support
branch
2 times, most recently
from
ec287d9 to
a3779e8
Compare
robmry
reviewed
Apr 24, 2025
tlsconfig/config.go
Outdated
| func IsErrEncryptedKey(err error) bool { | ||
| return errors.Is(err, x509.IncorrectPasswordError) | ||
| } | ||
| var errEncryptedKeyDeprecated = errors.New("private key is encrypted; support for encrypted private keys has been deprecated, see https://docs.docker.com/go/deprecated/") |
Contributor
There was a problem hiding this comment.
Deprecated by Go, but no longer allowed here ... so, should the message say obsolete or unsupported instead of deprecated?
Member
Author
There was a problem hiding this comment.
I was going back-and-forth a bit on the best error; initially I used the same one as we use in the CLI, which links to our docs.docker.com for the deprecation;
errors.New("private key is encrypted - support for encrypted private keys has been removed, see https://docs.docker.com/go/deprecated/")But I wasn't sure if we wanted to keep this module a bit separate from "docker", so tried to keep it a bit more agnostic, therefore linked to the Go issue.
Let me try to update it
Member
Author
There was a problem hiding this comment.
Oh! LOL, just realised that I did include the link to docs.docker.com.
Either way; I tweaked the error, but better suggestions more than welcome!
> Legacy PEM encryption as specified in RFC 1423 is insecure by design. Since > it does not authenticate the ciphertext, it is vulnerable to padding oracle > attacks that can let an attacker recover the plaintext From https://go-review.googlesource.com/c/go/+/264159 > It's unfortunate that we don't implement PKCS#8 encryption so we can't > recommend an alternative but PEM encryption is so broken that it's worth > deprecating outright. This feature allowed using an encrypted private key with a supplied password, but did not provide additional security as the encryption is known to be broken, and the key is sitting next to the password in the filesystem. Users are recommended to decrypt the private key, and store it un-encrypted to continue using it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_encrypted_key_support
branch
from
a3779e8 to
bc33254
Compare
robmry
approved these changes
Apr 24, 2025
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://go-review.googlesource.com/c/go/+/264159
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)