Skip to content

Conversation

@olljanat
Copy link
Contributor

Proposed changes

Added documentation about named pipe mounts.

Related issues (optional)

This documentation was requested on docker/cli/pull/1195

@GordonTheTurtle
Copy link

GordonTheTurtle commented Sep 26, 2018

Deploy preview for docsdocker ready!

Built with commit 3f3c585

https://deploy-preview-7427--docsdocker.netlify.com

@thaJeztah thaJeztah changed the title Included named pipe mounts documentation [19.03] Included named pipe mounts documentation Sep 27, 2018
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I found some small issues (commented inline).

So, this documentation change is for the next release (19.03), so should not be merged yet; I added [19.03] to the title so that the documentation maintainers know it's not to be merged yet; alternatively, you can change the PR to target the vnext-engine branch (which is a branch for upcoming releases); to do so; click the edit button;

screen shot 2018-09-27 at 10 19 17

And switch the target branch:

screen shot 2018-09-27 at 10 19 47

(I'm not sure if the vnext-engine branch is currently fully up-to-date: @ahh-docker is that branch still used by the docs team?)

@olljanat olljanat changed the base branch from master to vnext-engine September 27, 2018 16:19
@olljanat olljanat changed the base branch from vnext-engine to master September 27, 2018 16:19
@olljanat
Copy link
Contributor Author

@thaJeztah commit is now updated but I did change base from vnext-engine back to master as it looks to be quite lot of behind.

Btw. Do you know if there plan to publish 19.03 version of Docker EE? I'm just curious as that is version what is used by Windows Servers.

@bermudezmt
Copy link
Contributor

@thaJeztah Sorry for the delayed response, and thank you for updating the title. I have added a new label, content/unreleased for tracking purposes.

You are correct @olljanat - we haven't worked with vnext branches in almost a year; so using master as your base branch was the right call. Thank you for your patience - we will be merging this as soon as the code release is confirmed.

@bermudezmt bermudezmt added area/compose Relates to docker-compose.yml spec or docker-compose binary content/storage labels Mar 15, 2019
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrian-plata adrian-plata merged commit 500b9b1 into docker:master Jul 23, 2019
@adrian-plata
Copy link
Contributor

Merged, thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants