Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Mar 5, 2024

Signed-off-by: David Karlsson [email protected]

Description

Corrects a false statement that you can't connect to multiple networks
with the --network flag.

Related issues or tickets

Closes #19533

Corrects a false statement that you can't connect to multiple networks
with the `--network` flag.

Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn requested review from akerouanton and robmry March 5, 2024 13:16
@github-actions github-actions bot added the area/networking Relates to anything around networking label Mar 5, 2024
@netlify
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4028c50
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65e71b126ffd3d0008c795bf
😎 Deploy Preview https://deploy-preview-19566--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn requested a review from a team March 5, 2024 14:31
When a container starts, it can only attach to a single network, using the `--network` flag.
You can connect a running container to additional networks using the `docker network connect` command.
You can connect a running container to multiple networks,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be valuable to detail how the advanced --network format can be used to attach to multiple networks. I think the doc doesn't mention that right now. Here's the relevant PRs:

I think it might worth also mentioning how the CLI interprets top-level flags when multiple networks are specified.

@dvdksn dvdksn merged commit fb3182b into docker:main Mar 6, 2024
@dvdksn dvdksn deleted the multiple-nets branch March 6, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking Relates to anything around networking status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is some incorrect information on the Network page

4 participants