Add NetworkAttachmentConfig for service create/update #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannseman
force-pushed
the
network-attachment-config
branch
from
e81f980 to
1ed5f02
Compare
|
Please sign your commits following these rules: $ git clone -b "network-attachment-config" [email protected]:hannseman/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357812144
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Hannes Ljungberg <[email protected]>
Signed-off-by: Hannes Ljungberg <[email protected]>
Signed-off-by: Hannes Ljungberg <[email protected]>
hannseman
force-pushed
the
network-attachment-config
branch
from
1ed5f02 to
bcd61e4
Compare
Contributor
Author
|
Let me know if there's anything I can help with regarding this PR. Thanks! I've also opened a PR in moby to fix the documentation there: moby/moby#39495 |
shin-
approved these changes
Aug 27, 2019
Contributor
shin-
left a comment
shin-
left a comment
There was a problem hiding this comment.
Sorry it took so long! LGTM - thank you!
Contributor
Author
|
@shin- No problem! Thanks for the review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation makes it appear like the only way to attach networks to a service is to provide them as a list of strings of ids/names.
Attaching networks also support setting aliases and driver options. I've added the new type
docker.types.NetworkAttachmentConfigwhich is used to document these features.I also found that a documentation link to
ConfigReferencedid not work. It should be referenced asdocker.types.ConfigReference, this is now fixed.docker.types.ConfigReferencewas also referenced by its absolute path. I changed this to make the documentation a bit easier to read.