[master] static: windows: fix "docker-proxy.exe" being copied as "dockerd.exe" #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in 09541b5, which fixed the source-location of the docker-proxy binary, but accidentally used "dockerd.exe" as target. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_proxy_target
branch
from
b8e71f7 to
fc5379f
Compare
Member
Author
|
@fredericdalleau PTAL |
thaJeztah
changed the title
Member
Author
|
Looks like |
Member
Author
|
kicked CI again, and this time it worked 👍 |
djs55
approved these changes
Sep 9, 2021
djs55
left a comment
djs55
left a comment
There was a problem hiding this comment.
Looks like a very sensible change to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in 09541b5 (#554), which fixed the source-location of the docker-proxy binary, but accidentally used "dockerd.exe" as target.
fixes moby/moby#42609