-
Notifications
You must be signed in to change notification settings - Fork 161
[master] [TAR-610] [TAR-611] Build the daemon as part of the package building process #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Restores previous behavior when it comes to building the daemon plus its dependencies (docker-proxy, docker-init) Signed-off-by: Eli Uriegas <[email protected]>
dave-tucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Restores previous behavior when it comes to building the daemon plus its dependencies (docker-proxy, docker-init) Signed-off-by: Eli Uriegas <[email protected]> Signed-off-by: Eli Uriegas <[email protected]> Signed-off-by: Eli Uriegas <[email protected]>
|
As noted in docker/for-linux#452, version 19.05-ce still has the issue (missing support for devicemapper). |
|
@instantlinux There is no official |
|
Sorry, misread the version string: 18.09.5 is the version I found which is still problematic. The docker-ce edge releases have gotten shockingly WAY behind the current calendar date (8 months and counting). |
|
@instantlinux edge releases are no more; see https://blog.docker.com/2018/07/extending-support-cycle-docker-community-edition/ |
|
Got it, OK...Docker should overhaul its top-level website, there's a whole lot of information there rendered obsolete by that one blog entry. |
|
Do you mean the docs.docker.com website, or www.docker.com? (could you point to an example page that's problematic? then I can try forwarding that to the right team) |
|
It's the docs.docker.com site that needs attention. If you go to the main https://docs.docker.com/install/ section About Docker CE, the text reads about the same as it has for the past 3+ years and doesn't give a hint that "hey this stuff changed in the summer of 2018!" What I'd do is basically delete the whole discussion of the release versioning and nightly builds and phrase it entirely differently to present the material from a new-user's perspective along with a link to a page for the longtime-user audience. You could try tweaking it around the edges by (1) linking to one or more of the blog entries that you cited here to highlight past changes to the process, (2) providing far-better charts showing the available supported versions (with explicit references to the version strings that each distro accepts, e.g. "apt install docker-ce=18.09.bla-blah), and (3) making it clear that the calendar-date thing isn't really working anymore and that the company is now doing semver instead. |
Basically a reverse of #223.
Should hopefully resolve issues:
Tested with
docker engine activateanddocker engine update, which work as expected.cc @andrewhsu @thaJeztah