Skip to content

Conversation

@robmry
Copy link
Contributor

@robmry robmry commented Jul 15, 2024

- What I did

Depends on:

With that PR, rootlesskit-docker-proxy is no longer used or built.

- How I did it

Removed commands for installing rootlesskit-docker-proxy.

- How to verify it

Interesting question!

- Description for the changelog

The executable rootlesskit-docker-proxy is no longer required and has been removed.

@robmry robmry self-assigned this Jul 15, 2024

# docker-ce-rootless-extras install
install -D -m 0755 /usr/local/bin/rootlesskit debian/docker-ce-rootless-extras/usr/bin/rootlesskit
install -D -m 0755 /usr/local/bin/rootlesskit-docker-proxy debian/docker-ce-rootless-extras/usr/bin/rootlesskit-docker-proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still be installed for v27 and older

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the packaging isn't branched per release? I'll take a look tomorrow, thank you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 692a7f5 into docker:master Aug 16, 2024
@thaJeztah thaJeztah changed the title Remove 'rootlesskit-docker-proxy' [master] Remove 'rootlesskit-docker-proxy' Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants