Set packagename to containerd.io in version, and make it configurable #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
seemethere
previously approved these changes
Mar 14, 2019
Member
Author
|
I opened a backport PR for the 1.2 release branch, so once that's merged, we can merge this one for the next (1.2.6) release containerd/containerd#3098 |
The default is containerd.io
make deb
containerd --version
containerd containerd.io 20190314.103813~b858cfb4 b858cfb41b4f49d93990380faed2af5dd9269ffe
But can be overridden using the PACKAGE variable:
make PACKAGE=containerd.dev deb
containerd --version
containerd containerd.dev 20190314.103813~b858cfb4 b858cfb41b4f49d93990380faed2af5dd9269ffe
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Member
Author
|
removing "WIP" from this one; this should now work 👍 |
seemethere
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on
The default is containerd.io
But can be overridden using the PACKAGE variable:
Signed-off-by: Sebastiaan van Stijn [email protected]