fix various linting issues

[thaJeztah]

Got these when running locally on a more recent version of golangci-lint:

pkg/compose/build_bake.go:187:3: importShadow: shadow of imported from 'github.com/docker/cli/cli/command/image/build' package 'build' (gocritic)
                build := *service.Build
                ^
pkg/compose/build_bake.go:526:19: importShadow: shadow of imported from 'github.com/docker/cli/cli/command/image/build' package 'build' (gocritic)
func toBakeAttest(build types.BuildConfig) []string {
                  ^
pkg/compose/create.go:1453:2: importShadow: shadow of imported from 'github.com/docker/docker/api/types/network' package 'network' (gocritic)
        network string,
        ^
pkg/compose/create.go:1468:2: importShadow: shadow of imported from 'github.com/docker/docker/api/types/network' package 'network' (gocritic)
        network string,
        ^
pkg/compose/monitor.go:42:17: importShadow: shadow of imported from 'github.com/docker/compose/v2/pkg/api' package 'api' (gocritic)
func newMonitor(api client.APIClient, project string) *monitor {
                ^
cmd/compose/config.go:337:1: File is not properly formatted (gofumpt)
        return
^
pkg/compose/convergence.go:608:1: File is not properly formatted (gofumpt)
                return
^
pkg/compose/cp.go:335:1: File is not properly formatted (gofumpt)
                return
^
pkg/e2e/compose_up_test.go:35:10: go-require: c.RunDockerComposeCmd contains assertions that must only be used in the goroutine running the test function (testifylint)
                res := c.RunDockerComposeCmd(t, "-f", "fixtures/dependencies/deps-completed-successfully.yaml", "--project-name", projectName, "up", "--wait", "-d")
                       ^
pkg/e2e/healthcheck_test.go:42:10: go-require: c.RunDockerComposeCmd contains assertions that must only be used in the goroutine running the test function (testifylint)
                res := c.RunDockerComposeCmd(t, "-f", "fixtures/start_interval/compose.yaml", "--project-name", projectName, "up", "--wait", "-d", "test")
                       ^
10 issues:
* gocritic: 5
* gofumpt: 3
* testifylint: 2

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

[thaJeztah]

@glours ptal 🤗

[thaJeztah]

Boo! Failing again; don't think it should be related to my changes though;

#8 resolving provenance for metadata file
#8 DONE 0.0s
    compose_run_build_once_test.go:67: assertion failed: 2 (dbBuilds int) != 1 (int): db should build once, built 2 times
    --- FAIL: TestRunBuildOnce/nested_dependencies_build_only_once_each (3.93s)

=== FAIL: pkg/e2e TestRunBuildOnce (20.54s)
    compose_run_build_once_test.go:32: Running command: docker compose version
bar-1  | world
Docker Compose version c973238
    framework.go:144: Contents of config dir:

[glours]

Indeed it's not related to your changes, we already identified the root cause

[thaJeztah]

whoop! green now, @glours !