Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 20, 2025

What I did
Remove unused experiments and desktopClient so the Compose "backend" matches api.Service

Related issue
#13230

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested a review from a team as a code owner October 20, 2025 10:38
@ndeloof ndeloof requested a review from glours October 20, 2025 10:38
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/compose/desktop.go 0.00% 11 Missing ⚠️
pkg/compose/up.go 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@glours glours merged commit e25265d into docker:main Oct 20, 2025
25 checks passed
@ndeloof ndeloof deleted the cleanup branch October 20, 2025 14:03
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 23, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.40.1` -> `v2.40.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.40.2`](https://github.com/docker/compose/releases/tag/v2.40.2)

[Compare Source](docker/compose@v2.40.1...v2.40.2)

#### What's Changed

- Compose can't create a tar with adequate uid:gid ownership by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13299](docker/compose#13299)
- fail build if minimal required version of buildx isn't installed by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13295](docker/compose#13295)
- remove unused code to only rely on api.Service by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13300](docker/compose#13300)
- test digest or canonical reference, not only tag, when checking if an  image is already present by [@&#8203;glours](https://github.com/glours) in [#&#8203;13302](docker/compose#13302)
- introduce WithPrompt to configure compose backend to use a plugable UI component for user interaction by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13308](docker/compose#13308)

**Full Changelog**: <docker/compose@v2.40.1...v2.40.2>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTcuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE1Ny4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants