Skip to content

simpler stop UI #13064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

simpler stop UI #13064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cmd/formatter/ansi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ func restoreCursor() {
fmt.Print(ansi("8"))
}

func hideCursor() {
if disableAnsi {
return
}
fmt.Print(ansi("[?25l"))
}

func showCursor() {
if disableAnsi {
return
Expand Down
119 changes: 0 additions & 119 deletions cmd/formatter/stopping.go
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions pkg/compose/up.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ func (s *composeService) Up(ctx context.Context, project *types.Project, options
}
}

tui := formatter.NewStopping(logConsumer)
defer tui.Close()
logConsumer = tui

watcher, err := NewWatcher(project, options, s.watch, logConsumer)
if err != nil && options.Start.Watch {
return err
Expand All @@ -112,7 +108,7 @@ func (s *composeService) Up(ctx context.Context, project *types.Project, options
first := true
gracefulTeardown := func() {
first = false
tui.ApplicationTermination()
fmt.Println("Gracefully Stopping... press Ctrl+C again to force")
eg.Go(func() error {
return progress.RunWithLog(context.WithoutCancel(ctx), func(ctx context.Context) error {
return s.stop(ctx, project.Name, api.StopOptions{
Expand Down
Loading