Skip to content

make sure the post_start hooks fails #12996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

make sure the post_start hooks fails #12996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/e2e/fixtures/hooks/poststart/compose-error.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:

test:
image: alpine
image: nginx
post_start:
- command: sh -c 'echo env'
- command: sh -c 'command in error'
3 changes: 1 addition & 2 deletions pkg/e2e/hooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ func TestPostStartHookInError(t *testing.T) {

res := c.RunDockerComposeCmdNoCheck(t, "-f", "fixtures/hooks/poststart/compose-error.yaml", "--project-name", projectName, "up", "-d")
res.Assert(t, icmd.Expected{ExitCode: 1})
assert.Assert(t, strings.Contains(res.Combined(), "Error response from daemon: container"), res.Combined())
assert.Assert(t, strings.Contains(res.Combined(), "is not running"), res.Combined())
assert.Assert(t, strings.Contains(res.Combined(), "test hook exited with status 127"), res.Combined())
}

func TestPostStartHookSuccess(t *testing.T) {
Expand Down