Skip to content

Conversation

@sebastian-alfers
Copy link
Contributor

@sebastian-alfers sebastian-alfers commented Jul 25, 2025

Basic example to use the Akka SDK AI Agent component: https://doc.akka.io/concepts/ai-agents.html

@sebastian-alfers
Copy link
Contributor Author

Hey team, is there a chance we get a quick review on this? Much appreciated 🙏 @fiam

Copy link
Collaborator

@fiam fiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! Just some minor things.

akka/compose.yml Outdated
- postgres-db
ports:
- "9000:9000"
extra_hosts:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your application talk to host.docker.internal explicitly? Otherwise, I think you can safelyr remove this extra_hosts block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, seems this can be removed 👍

akka/compose.yml Outdated
STANDALONE_SINGLE_NODE: true
DB_HOST: "postgres-db"
HTTP_PORT: "9000"
OPENAI_API_KEY: ${OPENAI_API_KEY}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: could you please use a secret instead? There's an example for the compose.yaml bits here, and this Dockerfile shows how to read the secret. The file that holds the secret should also be added to .gitignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, fixed that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you fine with the current approach, @fiam ?

@fiam
Copy link
Collaborator

fiam commented Aug 27, 2025

@sebastian-alfers I'm trying to run this example, but it seems the poststart.sh file is missing. Could you please add it? Thanks!

@sebastian-alfers
Copy link
Contributor Author

I removed it for now, @fiam. Thanks for taking a look.

@fiam
Copy link
Collaborator

fiam commented Aug 28, 2025

Thanks @sebastian-alfers. To align it with the rest of the demos, could you please package it so it runs with just docker compose up --build without requiring any tools installed on the host other than Docker? I tried to do it myself, but I don't have experience with Java and I cannot get the service to start. Thanks!

@sebastian-alfers
Copy link
Contributor Author

@fiam Sounds like a good suggestion. I updated the pr.

@fiam
Copy link
Collaborator

fiam commented Sep 4, 2025

@fiam Sounds like a good suggestion. I updated the pr.

Looks like the approach on the PR depended on an image for the dependencies that was not multiplatform and failed on amd64. I took another crack at containerizing it and it seems I managed to make it work. Please, take a look at the Dockerfile and let me know if you're happy with that. Thanks!

@sebastian-alfers
Copy link
Contributor Author

Looks great, thanks @fiam!

@fiam
Copy link
Collaborator

fiam commented Sep 5, 2025

Thanks to you!

@fiam fiam merged commit 1303feb into docker:main Sep 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants