Skip to content

network: add --mac-address support to docker network connect #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ahmedharabi wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Draft

network: add --mac-address support to docker network connect #6728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab4470
Add --mac-address flag to network connect command
ahmedharabi Jan 2, 2026
e605695
WIP: review suggestions
thaJeztah Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cli/command/network/connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ type connectOptions struct {
container string
ipaddress net.IP // TODO(thaJeztah): we need a flag-type to handle netip.Addr directly
ipv6address net.IP // TODO(thaJeztah): we need a flag-type to handle netip.Addr directly
macAddress string // TODO(thaJeztah): we need a flag-type to handle net.HardwareAddr directly
links opts.ListOpts
aliases []string
linklocalips []net.IP // TODO(thaJeztah): we need a flag-type to handle []netip.Addr directly
Expand Down Expand Up @@ -60,6 +61,7 @@ func newConnectCommand(dockerCLI command.Cli) *cobra.Command {
flags.IPSliceVar(&options.linklocalips, "link-local-ip", nil, "Add a link-local address for the container")
flags.StringSliceVar(&options.driverOpts, "driver-opt", []string{}, "driver options for the network")
flags.IntVar(&options.gwPriority, "gw-priority", 0, "Highest gw-priority provides the default gateway. Accepts positive and negative values.")
flags.StringVar(&options.macAddress, "mac-address", "", "MAC address for the container on this network (e.g., 92:d0:c6:0a:29:33)")
return cmd
}

Expand All @@ -68,6 +70,14 @@ func runConnect(ctx context.Context, apiClient client.NetworkAPIClient, options
if err != nil {
return err
}

var macAddr network.HardwareAddr
if options.macAddress != "" {
if err := macAddr.UnmarshalText([]byte(options.macAddress)); err != nil {
return err
}
}

_, err = apiClient.NetworkConnect(ctx, options.network, client.NetworkConnectOptions{
Container: options.container,
EndpointConfig: &network.EndpointSettings{
Expand All @@ -80,6 +90,7 @@ func runConnect(ctx context.Context, apiClient client.NetworkAPIClient, options
Aliases: options.aliases,
DriverOpts: driverOpts,
GwPriority: options.gwPriority,
MacAddress: macAddr,
},
})
return err
Expand Down
1 change: 1 addition & 0 deletions docs/reference/commandline/network_connect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Connect a container to a network
| `--ip6` | `ip` | `<nil>` | IPv6 address (e.g., `2001:db8::33`) |
| [`--link`](#link) | `list` | | Add link to another container |
| `--link-local-ip` | `ipSlice` | | Add a link-local address for the container |
| `--mac-address` | `string` | | MAC address for the container on this network (e.g., 92:d0:c6:0a:29:33) |


<!---MARKER_GEN_END-->
Expand Down
Loading