Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 29, 2025

relates to:


Relates to cli@27b2797, which forked this type from the Moby API, and cli@aab947d, which fixed the deprecation comment.

This field is no longer used since Docker 1.11 (API version 1.23) through moby@aee260d and engine-api@9a9e468, and the fix of the deprecation comment was included in the 28.4.0 release.

This patch removes the field.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/config/types: remove deprecated `AuthConfig.Email` field.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Ah! Looks like we cut some corners and did a direct convert of the type, not mapping each field;

21.67 # github.com/docker/cli/cli/command
21.67 cli/command/registry.go:53:34: cannot convert a (variable of struct type "github.com/docker/cli/cli/config/types".AuthConfig) to type registry.AuthConfig
21.67 cli/command/registry.go:74:34: cannot convert authCfg (variable of struct type "github.com/docker/cli/cli/config/types".AuthConfig) to type registry.AuthConfig
21.67 cli/command/registry.go:189:65: cannot convert authConfig (variable of struct type "github.com/docker/cli/cli/config/types".AuthConfig) to type registry.AuthConfig

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Relates to [cli@27b2797], which forked this type from the Moby API, and
[cli@aab947d], which fixed the deprecation comment.

This field is no longer used since Docker 1.11 (API version 1.23) through
[moby@aee260d] and [engine-api@9a9e468], and the fix of the deprecation
comment was included in the 28.4.0 release.

This patch removes the field.

[cli@27b2797]: docker@27b2797
[cli@aab947d]: docker@aab947d
[moby@aee260d]: moby/moby@aee260d
[engine-api@9a9e468]: docker-archive-public/docker.engine-api@9a9e468

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@austinvazquez austinvazquez marked this pull request as ready for review September 29, 2025 22:58
@austinvazquez austinvazquez merged commit f8932e9 into docker:master Sep 29, 2025
100 of 101 checks passed
@thaJeztah thaJeztah deleted the rm_authconfig_email branch September 30, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/authentication impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants