cli/command/formatter: fix .Labels format being randomized #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
no need to initialize with an empty string Signed-off-by: Sebastiaan van Stijn <[email protected]>
The labels are stored as a map, causing the output to be randomized. This patch sorts the result to get a consistent output. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
- Coverage 55.10% 55.07% -0.04%
==========================================
Files 359 359
Lines 30046 30063 +17
==========================================
- Hits 16558 16557 -1
- Misses 12542 12555 +13
- Partials 946 951 +5 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)