golangci-lint: fix invalid nakedret config, disallow for any func length #5836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/internal/oauth/jwt.go:62:3: naked return in func `GetClaims` with 9 lines of code (nakedret)
return
^
cli/internal/oauth/jwt.go:67:2: naked return in func `GetClaims` with 9 lines of code (nakedret)
return
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
cli/command/container/cp.go:206:3: naked return in func `resolveLocalPath` with 5 lines of code (nakedret)
return
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The regex was added before we migrateed from gometalinter in dbd96ba, and got migrated to golangci-lint in b7e06f2. The format used for the config was invalid, and migrating it to the right format didn't make a difference, so we can remove it. As naked returns are generally not desirable, also setting the minimum func length to 0 (i.e., don't allow any naked returns), instead of the default Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (45.45%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5836 +/- ##
==========================================
- Coverage 59.18% 59.17% -0.01%
==========================================
Files 352 352
Lines 29548 29552 +4
==========================================
+ Hits 17487 17488 +1
- Misses 11080 11082 +2
- Partials 981 982 +1 |
vvoland
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/internal/oauth: don't use naked returns (nakedret)
cli/command/container: don't use naked returns (nakedret)
golangci-lint: fix invalid nakedret config, disallow for any func length
The regex was added before we migrateed from gometalinter in
dbd96ba (#620), and got migrated to golangci-lint
in b7e06f2 (#2173). The format used for the config
was invalid, and migrating it to the right format didn't make a difference,
so we can remove it.
As naked returns are generally not desirable, also setting the minimum func
length to 0 (i.e., don't allow any naked returns), instead of the default
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)