Skip to content

Conversation

@stevvooe
Copy link
Contributor

Signed-off-by: Stephen J Day [email protected]

Copy link
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi
Copy link
Member

LGTM

@codecov-io
Copy link

Codecov Report

Merging #577 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   49.38%   49.38%   -0.01%     
==========================================
  Files         208      208              
  Lines       17175    17178       +3     
==========================================
+ Hits         8482     8483       +1     
- Misses       8260     8262       +2     
  Partials      433      433

@andrewhsu
Copy link
Contributor

Related to changes introduced in #570:
0082310#diff-8868a5325011d98de3834041d1d2a913

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this PR addresses the integration-cli test failures we were seeing in docker-ce

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah added this to the 17.10.0 milestone Sep 30, 2017
@thaJeztah thaJeztah merged commit 583015b into docker:master Sep 30, 2017
@stevvooe stevvooe deleted the allocate-channel branch October 2, 2017 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants