Fixed import in loader.go #558
Conversation
|
Please sign your commits following these rules: $ git clone -b "fix-import" [email protected]:surajnarwade/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Sorry, but this change is not correct
| "sort" | ||
| "strings" | ||
|
|
||
| "github.com/Sirupsen/logrus" |
There was a problem hiding this comment.
This doesn't look correct; the repository was renamed from Sirupsen/logrus to sirupsen/logrus (see a0113c3, and #424)
The correct import path is now with a lowercase s: sirupsen/logrus#553
|
Closing per my comment above, but feel free to comment after that |
|
@thaJeztah , URL looks like https://github.com/Sirupsen/logrus and it's breaking the code |
|
@thaJeztah my bad, I have not seen that issue before but somehow that is breaking my kompose code |
|
@surajnarwade the problem is that with the rename, once a dependency has update logrus to reference it with the lowercase |
|
@vdemeester thanks for clearing thing |
4 participants
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)