Skip to content

Conversation

@jsternberg
Copy link
Contributor

- What I did

Errors returned by otel shutdown and force flush methods are passed to otel.Handle to be determined how or if they'll be printed.

- How I did it

Checked for the error and invoked otel.Handle.

- How to verify it

- Description for the changelog

* Print OTEL errors in the CLI on shutdown

- A picture of a cute animal (not mandatory but encouraged)

@laurazard
Copy link
Collaborator

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (a4619f3) to head (b1956f5).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5444      +/-   ##
==========================================
- Coverage   59.75%   59.74%   -0.01%     
==========================================
  Files         345      345              
  Lines       23428    23430       +2     
==========================================
  Hits        13999    13999              
- Misses       8455     8457       +2     
  Partials      974      974              

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants