-
Notifications
You must be signed in to change notification settings - Fork 2.1k
command: check for wsl mount path on windows #5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package command | ||
|
|
||
| import ( | ||
| "net/url" | ||
| "testing" | ||
| "testing/fstest" | ||
|
|
||
| "gotest.tools/v3/assert" | ||
| ) | ||
|
|
||
| func TestWslSocketPath(t *testing.T) { | ||
| u, err := url.Parse("unix:////./c:/my/file/path") | ||
| assert.NilError(t, err) | ||
|
|
||
| // Ensure host is empty. | ||
| assert.Equal(t, u.Host, "") | ||
|
|
||
| // Use a filesystem where the WSL path exists. | ||
| fs := fstest.MapFS{ | ||
| "mnt/c/my/file/path": {}, | ||
| } | ||
| assert.Equal(t, wslSocketPath(u.Path, fs), "/mnt/c/my/file/path") | ||
|
|
||
| // Use a filesystem where the WSL path doesn't exist. | ||
| fs = fstest.MapFS{ | ||
| "my/file/path": {}, | ||
| } | ||
| assert.Equal(t, wslSocketPath(u.Path, fs), "") | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an error (or warning -> ignore) instead? i.e., should we only accept
unix://and only accept forward-slashes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly just to make sure the output is correct. I don't think this needs to be an error or warning. The reason why it's here and not somewhere else is it communicates that the requirement for forward slashes comes from the URL format. We could move this call into
wslSocketPathand it would be fine, but we'd want to add a comment along the lines of "using forward slashes so this is compatible with a URL" so why not just have the code where we're constructing the URL?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the
unix:// +here isn't to just add the prefix back in @thaJeztah, it's just re-adding the prefix we cut out when we parsed the URL/transformed the path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right; overlooked that part.
I guess we could've written back to
u.Path, and returnedu.String()😅Either way; it's probably ok for now; we can do follow-ups