Skip to content

Conversation

@thaJeztah
Copy link
Member

commit 89db01e added these tracing modules as dependency, but did not require the otlptracehttp module. This module was added later through f0a29af as indirect dependency for docker/docker. The otlptracehttp and otlptracegrpc modules have no dependency between each-other, but similar to their otlpmetric cousins, are preferred to be on the same version.

This patch aligns their versions. No changes in vendored code;

full diff: open-telemetry/opentelemetry-go@exporters/otlp/otlptrace/otlptracehttp/v1.19.0...exporters/otlp/otlptrace/otlptracehttp/v1.21.0

- A picture of a cute animal (not mandatory but encouraged)

…tp v1.21.0

commit 89db01e added these tracing modules
as dependency, but did not require the otlptracehttp module. This module
was added later through f0a29af as indirect
dependency for docker/docker. The otlptracehttp and otlptracegrpc modules
have no dependency between each-other, but similar to their otlpmetric
cousins, are preferred to be on the same version.

This patch aligns their versions. No changes in vendored code;

full diff: open-telemetry/opentelemetry-go@exporters/otlp/otlptrace/otlptracehttp/v1.19.0...exporters/otlp/otlptrace/otlptracehttp/v1.21.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.45%. Comparing base (ddd4c39) to head (40a5b29).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5311   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files         299      299           
  Lines       20855    20855           
=======================================
  Hits        12816    12816           
  Misses       7124     7124           
  Partials      915      915           

@laurazard laurazard merged commit 93ee2e6 into docker:master Aug 2, 2024
@thaJeztah thaJeztah deleted the vendor_otel_trace branch October 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants