cli/command/container: TestSplitCpArg: cleaner skip #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5230 +/- ##
=======================================
Coverage 61.48% 61.48%
=======================================
Files 298 298
Lines 20813 20813
=======================================
Hits 12797 12797
Misses 7104 7104
Partials 912 912 |
Member
Author
|
Let me know if you like this better, @vvoland (happy to update) |
vvoland
reviewed
Jul 4, 2024
cli/command/container/cp_test.go
Outdated
| tc := tc | ||
| t.Run(tc.doc, func(t *testing.T) { | ||
| skip.If(t, tc.os == "windows" && runtime.GOOS != "windows" || tc.os == "linux" && runtime.GOOS == "windows") | ||
| nonMatchingPlatform := tc.os == "windows" && runtime.GOOS != "windows" || tc.os == "unix" && runtime.GOOS == "windows" |
Collaborator
There was a problem hiding this comment.
I was mostly concerned about splitting the OR'd parts into a separate variables to be honest 😅
a := tc.os == "windows" && runtime.GOOS != "windows"
b := tc.os == "unix" && runtime.GOOS == "windows"
skip.If(t, a || b)Mostly because it's easier to wrap your head about the end-result by looking at each of them separately, instead of trying to parse the whole 4 product expression.
Member
Author
There was a problem hiding this comment.
Split it over 2 checks (I tried to avoid the skip.If(t, a || b) because the output looks weird in the logs 😂
But again; happy to change if you prefer it differently ❤️
Trying to make the logic slightly clearer, and adding a custom
message for the skip,
Before this:
=== RUN TestSplitCpArg/absolute_path_with_drive
cp_test.go:184: tc.os == "windows" && runtime.GOOS != "windows" || tc.os == "linux" && runtime.GOOS == "windows"
After this:
=== RUN TestSplitCpArg/absolute_path_with_drive
cp_test.go:184: skipping windows test on non-windows platform
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make the logic slightly clearer, and adding a custom message for the skip,
Before this:
After this: