Skip to content

Conversation

@andrewhsu
Copy link
Contributor

@andrewhsu andrewhsu commented Sep 8, 2017

- What I did

Primarily to bring in fix for:

Although there are several other changes that are in this update:
moby/moby@184cea5...ea220e7

I also had to update vndr for golang.org/x/sys to bring in changes required by the moby/moby re-vndr: golang/sys@7397344...07c1829

- How I did it

$ make -f docker.Makefile shell
$ vi vendor.conf
$ vndr github.com/docker/docker
$ vndr golang.org/x/sys

- How to verify it

run vndr again and see nothing changes

- Description for the changelog

  • update vndr of docker/docker and golang.org/x/sys to bring in fixes for arm

- A picture of a cute animal (not mandatory but encouraged)

🐸

Primarily to bring in fix for "Clear Architecture field in platform
constraint for arm architectures".

Signed-off-by: Andrew Hsu <[email protected]>
@andrewhsu
Copy link
Contributor Author

cc @nishanttotla @tiborvass @dnephin

Copy link
Contributor

@nishanttotla nishanttotla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (the arm commit is there and looks good. Can't comment on the rest of the commit tree also being vendored in)

@dnephin
Copy link
Contributor

dnephin commented Sep 11, 2017

Looks like golang.org/x/sys needs to be updated to 07c182904dbd53199946ba614a412c61d3c548f5

@dnephin
Copy link
Contributor

dnephin commented Sep 11, 2017

Please also remove github.com/docker/libtrust from vendor.conf, it looks like it is no longer needed. There should be a warning come from vndr about that.

To satisfy requirements of the vndr of docker/docker

Signed-off-by: Andrew Hsu <[email protected]>
@andrewhsu
Copy link
Contributor Author

@dnephin looks like build got cancelled because of circleci something something. is there a way to poke it again?

@codecov-io
Copy link

codecov-io commented Sep 12, 2017

Codecov Report

Merging #516 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   49.06%   49.04%   -0.02%     
==========================================
  Files         200      200              
  Lines       16407    16411       +4     
==========================================
- Hits         8050     8049       -1     
- Misses       7938     7942       +4     
- Partials      419      420       +1

@andrewhsu
Copy link
Contributor Author

git commit --amend is my friend now

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vieux
Copy link
Contributor

vieux commented Sep 12, 2017

LGTM

@vieux vieux merged commit b604132 into docker:master Sep 12, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Sep 12, 2017
@andrewhsu andrewhsu deleted the v branch September 13, 2017 00:12
@StefanScherer
Copy link
Member

@andrewhsu Just got a RPi3 with internet connection and installed docker-ce_17.09.0cerc3-0~raspbian_armhf.deb, created a swarm and I'm able to create swarm services 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants