-
Notifications
You must be signed in to change notification settings - Fork 2.1k
vndr docker/docker to ea220e7 to bring in fix for arm #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Primarily to bring in fix for "Clear Architecture field in platform constraint for arm architectures". Signed-off-by: Andrew Hsu <[email protected]>
nishanttotla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (the arm commit is there and looks good. Can't comment on the rest of the commit tree also being vendored in)
|
Looks like |
|
Please also remove |
To satisfy requirements of the vndr of docker/docker Signed-off-by: Andrew Hsu <[email protected]>
|
@dnephin looks like build got cancelled because of circleci something something. is there a way to poke it again? |
Signed-off-by: Andrew Hsu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 49.06% 49.04% -0.02%
==========================================
Files 200 200
Lines 16407 16411 +4
==========================================
- Hits 8050 8049 -1
- Misses 7938 7942 +4
- Partials 419 420 +1 |
|
|
dnephin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM |
|
@andrewhsu Just got a RPi3 with internet connection and installed docker-ce_17.09.0 |
- What I did
Primarily to bring in fix for:
Although there are several other changes that are in this update:
moby/moby@184cea5...ea220e7
I also had to update vndr for golang.org/x/sys to bring in changes required by the moby/moby re-vndr: golang/sys@7397344...07c1829
- How I did it
- How to verify it
run vndr again and see nothing changes
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐸