-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docker info: include Client Version and "platform name" #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3b615a to
4a97677
Compare
2 tasks
4a97677 to
cf443e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4180 +/- ##
=======================================
Coverage 59.04% 59.05%
=======================================
Files 288 288
Lines 24775 24793 +18
=======================================
+ Hits 14629 14641 +12
- Misses 9262 9267 +5
- Partials 884 885 +1 |
It's defined on a non-exported type, and was only used in a template. Replacing for a basic "nil" check, which should do the same. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The Platform field was defined with omitempty, but would always be shown in the JSON output, because it was never nil. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows the type to be used for situations where this information is not present, or not to be printed. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch adds additional information to the Client section of the output.
We were already outputting versions of CLI Plugins, and the Server, but not
for the Client.
Adding this information can help with bug-reports where the reporter only
provided the `docker info` output, or (e.g.) only `docker --version`. The
platform name helps identify what kind of builds the user has installed
(e.g. docker's docker-ce packages have "Docker Engine - Community" set
for this), although we should consider including "packager" information
as a more formalized field for this information.
Before this patch:
$ docker info
Client:
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.10.4
Path: /usr/libexec/docker/cli-plugins/docker-buildx
...
With this patch applied:
$ docker info
Client: Docker Engine - Community
Version: 24.0.0-dev
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.10.4
Path: /usr/libexec/docker/cli-plugins/docker-buildx
...
Signed-off-by: Sebastiaan van Stijn <[email protected]>
cf443e9 to
8ee7711
Compare
rumpl
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/system: move ServerOK() together with type definition
cli/command/system: add platformInfo type, and fix "omitempty"
The Platform field was defined with omitempty, but would always be shown
in the JSON output, because it was never nil.
cli/command/system: clientVersion: make all fields "omitempty"
This allows the type to be used for situations where this information is not present,
or not to be printed.
cli/command/system: add newClientVersion() utility
docker info: include Client Version and "platform name"
This patch adds additional information to the Client section of the output.
We were already outputting versions of CLI Plugins, and the Server, but not
for the Client.
Adding this information can help with bug-reports where the reporter only
provided the
docker infooutput, or (e.g.) onlydocker --version. Theplatform name helps identify what kind of builds the user has installed
(e.g. docker's docker-ce packages have "Docker Engine - Community" set
for this), although we should consider including "packager" information
as a more formalized field for this information.
Before this patch:
With this patch applied:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)