remove various deprecated types and functions #4146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
thaJeztah
commented
Apr 1, 2023
Comment on lines
7
to
9
| // InStream is an input stream used by the DockerCli to read user input | ||
| // Deprecated: Use github.com/docker/cli/cli/streams.In instead | ||
| type InStream = streams.In |
Member
Author
There was a problem hiding this comment.
Cory pointed out that the deprecation in this package used the wrong format (missing a newline). While most editors/IDEs may pick this up, Golang itself doesn't, which means that pkg.go.dev doesn't show it as deprecated (and Linters may not be warning about it); https://pkg.go.dev/github.com/docker/[email protected]+incompatible/cli/command#InStream
I had a quick look if I could find external consumers of this, and only found 2 (both were using a very old version of docker (1.4.0), so likely no concern, but "just in case";
- I'll remove this commit from this PR
- Open a PR to fix the comments (and cherry-pick that into the 23.0 branch)
- Create a new draft PR to remove this (but for the 25.0 release, and we can merge that once we created the 24.0 branch)
Member
Author
There was a problem hiding this comment.
- ^^ removed that commit, and opened cli/command: fix deprecation comments for Stream types #4152
This was deprecated in 467e650, which is part of docker 23.0, so users should have had a chance to migrate. Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were deprecated in de6020a, which is part of docker 23.0, so users should have had a chance to migrate. This removes IsErrContextDoesNotExist() and IsErrTLSDataDoesNotExist() Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were deprecated in 3499669, which is part of docker 23.0, so users should have had a chance to migrate. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This field was deprecated in 15535d4, which is part of docker 23.0, so users should have had a chance to migrate. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This field was deprecated in 6ea2767, which is part of docker 23.0, so users should have had a chance to migrate. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_deprecated_bits
branch
from
800c3b7 to
66a1c3b
Compare
Member
Author
|
@vvoland @laurazard ptal |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4146 +/- ##
==========================================
+ Coverage 59.03% 59.04% +0.01%
==========================================
Files 287 287
Lines 24767 24761 -6
==========================================
Hits 14620 14620
+ Misses 9264 9258 -6
Partials 883 883 |
vvoland
approved these changes
Apr 3, 2023
rumpl
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/formatter: remove deprecated KubernetesEndpoint
This was deprecated in 467e650 (#3440), which
is part of docker 23.0, so users should have had a chance to migrate.
cli/context/store: remove deprecated error-utilities
These were deprecated in de6020a (#3790), which
is part of docker 23.0, so users should have had a chance to migrate.
This removes IsErrContextDoesNotExist() and IsErrTLSDataDoesNotExist()
cli/context/store: remove deprecated IsErrTLSDataDoesNotExist()
These were deprecated in de6020a (#3790), which
is part of docker 23.0, so users should have had a chance to migrate.
cli/flags: remove deprecated CommonOptions, NewCommonOptions
These were deprecated in 3499669 (#3876), which
is part of docker 23.0, so users should have had a chance to migrate.
cli/context/docker: remove deprecated Endpoint.TLSPassword
This field was deprecated in 15535d4 (#3218), which
is part of docker 23.0, so users should have had a chance to migrate.
cli/config/configfile: remove deprecated StackOrchestrator field
This field was deprecated in 6ea2767 (#3440), which
is part of docker 23.0, so users should have had a chance to migrate.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)