context: minor refactoring and fixes #3887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents unexpected bugs if fields are added/moved. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This makes it more transparent what's happening. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Store a reference to the options in the client, so that they are available for later use. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/context
kind/refactor
Member
Author
|
/cc @silvin-lubecki @vvoland ptal 🤗 |
vvoland
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: NewTopLevelCommand: don't use unnamed assignments
This prevents unexpected bugs if fields are added/moved.
cli/command: remove DockerCli.loadConfigFile()
This makes it more transparent what's happening.
cli/command: DockerCli: keep reference to options for later use
Store a reference to the options in the client, so that they are available for later use.