Skip to content

Fix-up (gometalinter) linting config #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvin-lubecki merged 1 commit into from
Oct 25, 2019
Merged

Fix-up (gometalinter) linting config #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gometalinter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@
"Vendor": true,
"Deadline": "2m",
"Sort": ["linter", "severity", "path", "line"],
"Exclude": [
"Skip": [
"cli/compose/schema/bindata.go",
"cli/command/stack/kubernetes/api/openapi",
"cli/command/stack/kubernetes/api/client",
".*generated.*",
"parameter .* always receives"
"vendor"
],
"Exclude": [
"parameter .* always receives",
"_esc(Dir|FS|FSString|FSMustString) is unused"
Copy link
Contributor

@kolyshkin kolyshkin Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message does not explain where this line is coming from

Copy link
Member Author

@thaJeztah thaJeztah Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahm, yes. Those are from the cli/compose/schema/bindata.go file. Looks like some linters don't get passed the Skip configuration correctly, and still invalidate.

We really need to get rid of gometalinter in this repository; there's a WIP pull request #1797, but I need to find some time to carry it.

],
"EnableGC": true,
"Linters": {
Expand Down