Skip to content

vendor: align with engine at b6684a403c99aaf6be5b8ce0bef3c6650fcdcd12 #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silvin-lubecki merged 3 commits into from
Oct 7, 2019
Merged

vendor: align with engine at b6684a403c99aaf6be5b8ce0bef3c6650fcdcd12 #2110

silvin-lubecki merged 3 commits into from
Oct 7, 2019

Conversation

@tiborvass
Copy link
Collaborator

@tiborvass tiborvass commented Sep 26, 2019 •
edited
Loading

Testdata in cli/command/system/testdata needed "OSVersion":"" to be added.

@tiborvass tiborvass requested a review from thaJeztah September 26, 2019 22:54
@tiborvass tiborvass mentioned this pull request Sep 26, 2019
Merged
thaJeztah
thaJeztah reviewed Oct 1, 2019
View reviewed changes
@tiborvass
Copy link
Collaborator Author

tiborvass commented Oct 2, 2019

@thaJeztah updated!

@thaJeztah
Copy link
Member

thaJeztah commented Oct 2, 2019 •
edited
Loading

argh, sorry, meant go-winio and grpc each in their own commit 😅😔🤗

Tibor Vass added 2 commits October 2, 2019 17:47
@tiborvass
Copy link
Collaborator Author

tiborvass commented Oct 2, 2019

@thaJeztah updated! I didn't see the "s" of commits in bumps to separate commits

thaJeztah
thaJeztah approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

thaJeztah commented Oct 2, 2019

@silvin-lubecki @kolyshkin PTAL

@crosbymichael
Copy link
Contributor

crosbymichael commented Oct 7, 2019

LGTM

silvin-lubecki
silvin-lubecki approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 3e07fa7 into docker:master Oct 7, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Oct 7, 2019
@thaJeztah thaJeztah mentioned this pull request Nov 26, 2019
Closed
@tiborvass tiborvass mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tiborvass @thaJeztah @crosbymichael @silvin-lubecki @GordonTheTurtle