cli/config: use os.UserHomeDir instead of github.com/docker/docker/pkg/homedir #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/homedir Signed-off-by: Tibor Vass <[email protected]>
Collaborator
Author
|
Ping @jonjohnsonjr @dmcgowan this is the minimalist implementation. |
Contributor
|
@tiborvass is it possible to make this not panic in |
Collaborator
Author
|
@jonjohnsonjr done! #2106 |
This was referenced Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change was reverted in #2111
Signed-off-by: Tibor Vass [email protected]
This is to avoid too many dependencies as outlined in #2082
Note that, this PR greatly (aka over-) simplifies the homedir logic: it requires HOME envvar to be set, and no longer looks at the current user's homedir via user.Current().HomeDir, as pkg/homedir did.