Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 13, 2019

@thaJeztah thaJeztah changed the title bump github.com/xeipuuv/gojsonschema v1.1.0 [WIP] bump github.com/xeipuuv/gojsonschema v1.1.0 Apr 13, 2019
@thaJeztah thaJeztah force-pushed the bump_go_json_schema_1.1.0 branch from 2d8d633 to 22a2b2c Compare April 13, 2019 08:43
@thaJeztah thaJeztah changed the title [WIP] bump github.com/xeipuuv/gojsonschema v1.1.0 bump github.com/xeipuuv/gojsonschema v1.1.0 Apr 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #1827 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   56.73%   56.72%   -0.02%     
==========================================
  Files         308      308              
  Lines       21610    21613       +3     
==========================================
- Hits        12261    12259       -2     
- Misses       8449     8453       +4     
- Partials      900      901       +1

@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3e07fa7). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master    #1827   +/-   ##
=========================================
  Coverage          ?   56.75%           
=========================================
  Files             ?      308           
  Lines             ?    21614           
  Branches          ?        0           
=========================================
  Hits              ?    12267           
  Misses            ?     8449           
  Partials          ?      898

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah force-pushed the bump_go_json_schema_1.1.0 branch from 22a2b2c to 67ed9c1 Compare April 18, 2019 17:24
@thaJeztah
Copy link
Member Author

rebased

@thaJeztah
Copy link
Member Author

ping @vdemeester ptal 🤗

@sreeramaraju
Copy link

Hi, is merging these changes to Master still in pipeline?

@thaJeztah
Copy link
Member Author

I think so, but I see it needs a minor rebase 😅 - will do so right away

@thaJeztah thaJeztah force-pushed the bump_go_json_schema_1.1.0 branch from 67ed9c1 to 06f34ba Compare October 10, 2019 22:26
…39b5fc5bb

full diff: xeipuuv/gojsonpointer@4e3ac27...02993c4

only a gofmt and documentation change

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

Rebased; also updated https://github.com/xeipuuv/gojsonpointer to current master

xeipuuv/gojsonpointer@4e3ac27...02993c4

(only a gofmt change)

@thaJeztah
Copy link
Member Author

ping @vdemeester @kolyshkin ptal 🤗

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit 83d0c5d into docker:master Oct 11, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Oct 11, 2019
@thaJeztah thaJeztah deleted the bump_go_json_schema_1.1.0 branch October 11, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants