Skip to content

Conversation

@thaJeztah
Copy link
Member

go1.12.2 (released 2019/04/05) includes fixes to the compiler, the go
command, the runtime, and the doc, net, net/http/httputil, and os packages.
See the Go 1.12.2 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.2

Full diff: golang/go@go1.12.1...go1.12.2

go1.12.2 (released 2019/04/05) includes fixes to the compiler, the go
command, the runtime, and the doc, net, net/http/httputil, and os packages.
See the Go 1.12.2 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.2

Full diff: golang/go@go1.12.1...go1.12.2

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the bump_golang_1.12.2 branch from b776bce to ed8733a Compare April 8, 2019 16:53
@thaJeztah
Copy link
Member Author

ping @ijc @silvin-lubecki @vdemeester

@codecov-io
Copy link

Codecov Report

Merging #1816 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         308      308           
  Lines       21391    21391           
=======================================
  Hits        12047    12047           
  Misses       8465     8465           
  Partials      879      879

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, I was about to bump it too!

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit f019bdc into docker:master Apr 8, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.12.2 branch April 8, 2019 18:57
@@ -1,4 +1,4 @@
FROM dockercore/golang-cross:1.12.1@sha256:8541e3aea7b2cffb7ac310af250e34551abe2ec180c77d5a81ae3d52a47ac779
FROM dockercore/golang-cross:1.12.2@sha256:ea93d7ed5b464e5163cf8df40a198ad54afe6a59e1ca335c9bc4a5ed3702f2d0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually thinking of removing this "pin by digest", as it doesn't add much for our use-case 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants