-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Bump Golang 1.12.2 #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Golang 1.12.2 #1816
Conversation
go1.12.2 (released 2019/04/05) includes fixes to the compiler, the go command, the runtime, and the doc, net, net/http/httputil, and os packages. See the Go 1.12.2 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.12.2 Full diff: golang/go@go1.12.1...go1.12.2 Signed-off-by: Sebastiaan van Stijn <[email protected]>
b776bce to
ed8733a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 308 308
Lines 21391 21391
=======================================
Hits 12047 12047
Misses 8465 8465
Partials 879 879 |
silvin-lubecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you, I was about to bump it too!
cpuguy83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -1,4 +1,4 @@ | |||
| FROM dockercore/golang-cross:1.12.1@sha256:8541e3aea7b2cffb7ac310af250e34551abe2ec180c77d5a81ae3d52a47ac779 | |||
| FROM dockercore/golang-cross:1.12.2@sha256:ea93d7ed5b464e5163cf8df40a198ad54afe6a59e1ca335c9bc4a5ed3702f2d0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually thinking of removing this "pin by digest", as it doesn't add much for our use-case 🤔
go1.12.2 (released 2019/04/05) includes fixes to the compiler, the go
command, the runtime, and the doc, net, net/http/httputil, and os packages.
See the Go 1.12.2 milestone on our issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.12.2
Full diff: golang/go@go1.12.1...go1.12.2