-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace gometalinter with Golangci lint #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c38ca4c
opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (s…
silvin-lubecki 65808fc
cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result …
silvin-lubecki b2158b2
cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks …
silvin-lubecki fcbd937
SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (stati…
silvin-lubecki 63bf41f
cli/command/trust/key_generate.go:112:9: nilness: impossible conditio…
silvin-lubecki 0d5c8d0
cli/command/stack/kubernetes/list.go:32:47: nilness: tautological con…
silvin-lubecki 27ebbbe
cli/command/container/start.go:157:20: nilness: nil dereference in ty…
silvin-lubecki 68a8b2c
cli/registry/client/fetcher.go:106:9: nilness: impossible condition: …
silvin-lubecki 31e233b
cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:"…
silvin-lubecki 0850214
opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor…
silvin-lubecki 2fc15a6
cli/command/container/attach.go:141:15: nilness: impossible condition…
silvin-lubecki d5bbb94
unchecked errors
silvin-lubecki 3c4788a
cli/command/image/build/context_test.go:244:38: `createTestTempDir` -…
silvin-lubecki 321aff9
cli/command/image/build/context_test.go:252:71: `createTestTempFile` …
silvin-lubecki 216bedc
cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (erro…
silvin-lubecki 5abbbfc
cli/command/image/build_session.go:133:45: getBuildSharedKey - result…
silvin-lubecki 65237e7
cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unu…
silvin-lubecki 8f98106
cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferen…
silvin-lubecki d110697
cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (…
silvin-lubecki c014ec1
cli/compose/convert/service.go:592:76: convertDNSConfig - result 1 (e…
silvin-lubecki 7a47e81
disable unparam linter on these functions, as we need an error in the…
silvin-lubecki 2f09e17
cli/context/kubernetes/endpoint_test.go:122:38: `checkClientConfig` -…
silvin-lubecki f443ad3
Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` …
silvin-lubecki 02091c1
Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPas…
silvin-lubecki cd030a1
cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconv…
silvin-lubecki 4a7a541
File is not `goimports`-ed (goimports)
silvin-lubecki 54cab47
cli/compose/convert/service_test.go:274:72: unnecessary conversion (u…
silvin-lubecki 06908e0
cli/command/registry/login_test.go:66:25: unnecessary conversion (unc…
silvin-lubecki e62ed7a
cli/command/image/build/context_test.go:244:38: `createTestTempDir` -…
silvin-lubecki fbf90f3
Remove now obsolete gometalinter and use golangci-lint instead with a…
silvin-lubecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if it would be smart enough to accept it if we'd define a type for this;
cli/cli/compose/loader/loader.go
Lines 290 to 293 in 9a39a10