Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c38ca4c
opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (s…
silvin-lubecki Apr 2, 2019
65808fc
cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result …
silvin-lubecki Apr 2, 2019
b2158b2
cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks …
silvin-lubecki Apr 2, 2019
fcbd937
SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (stati…
silvin-lubecki Apr 2, 2019
63bf41f
cli/command/trust/key_generate.go:112:9: nilness: impossible conditio…
silvin-lubecki Apr 2, 2019
0d5c8d0
cli/command/stack/kubernetes/list.go:32:47: nilness: tautological con…
silvin-lubecki Apr 2, 2019
27ebbbe
cli/command/container/start.go:157:20: nilness: nil dereference in ty…
silvin-lubecki Apr 2, 2019
68a8b2c
cli/registry/client/fetcher.go:106:9: nilness: impossible condition: …
silvin-lubecki Apr 2, 2019
31e233b
cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:"…
silvin-lubecki Apr 2, 2019
0850214
opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor…
silvin-lubecki Apr 2, 2019
2fc15a6
cli/command/container/attach.go:141:15: nilness: impossible condition…
silvin-lubecki Apr 2, 2019
d5bbb94
unchecked errors
silvin-lubecki Apr 2, 2019
3c4788a
cli/command/image/build/context_test.go:244:38: `createTestTempDir` -…
silvin-lubecki Apr 2, 2019
321aff9
cli/command/image/build/context_test.go:252:71: `createTestTempFile` …
silvin-lubecki Apr 2, 2019
216bedc
cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (erro…
silvin-lubecki Apr 2, 2019
5abbbfc
cli/command/image/build_session.go:133:45: getBuildSharedKey - result…
silvin-lubecki Apr 2, 2019
65237e7
cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unu…
silvin-lubecki Apr 2, 2019
8f98106
cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferen…
silvin-lubecki Apr 2, 2019
d110697
cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (…
silvin-lubecki Apr 2, 2019
c014ec1
cli/compose/convert/service.go:592:76: convertDNSConfig - result 1 (e…
silvin-lubecki Apr 2, 2019
7a47e81
disable unparam linter on these functions, as we need an error in the…
silvin-lubecki Apr 2, 2019
2f09e17
cli/context/kubernetes/endpoint_test.go:122:38: `checkClientConfig` -…
silvin-lubecki Apr 2, 2019
f443ad3
Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` …
silvin-lubecki Apr 2, 2019
02091c1
Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPas…
silvin-lubecki Apr 2, 2019
cd030a1
cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconv…
silvin-lubecki Apr 2, 2019
4a7a541
File is not `goimports`-ed (goimports)
silvin-lubecki Apr 2, 2019
54cab47
cli/compose/convert/service_test.go:274:72: unnecessary conversion (u…
silvin-lubecki Apr 2, 2019
06908e0
cli/command/registry/login_test.go:66:25: unnecessary conversion (unc…
silvin-lubecki Apr 2, 2019
e62ed7a
cli/command/image/build/context_test.go:244:38: `createTestTempDir` -…
silvin-lubecki Apr 2, 2019
fbf90f3
Remove now obsolete gometalinter and use golangci-lint instead with a…
silvin-lubecki Apr 2, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cli/compose/loader/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ func transformServiceVolumeConfig(data interface{}) (interface{}, error) {
}
}

// nolint: unparam
func transformServiceNetworkMap(value interface{}) (interface{}, error) {
if list, ok := value.([]interface{}); ok {
mapValue := map[interface{}]interface{}{}
Expand All @@ -764,6 +765,7 @@ func transformServiceNetworkMap(value interface{}) (interface{}, error) {
return value, nil
}

// nolint: unparam
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if it would be smart enough to accept it if we'd define a type for this;

Func func(interface{}) (interface{}, error)
}
func createTransformHook(additionalTransformers ...Transformer) mapstructure.DecodeHookFuncType {

func transformStringOrNumberList(value interface{}) (interface{}, error) {
list := value.([]interface{})
result := make([]string, len(list))
Expand Down