Add systctl support for services #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @dperny @silvin-lubecki @vdemeester ptal |
thaJeztah
force-pushed
the
add_sysctls_for_services
branch
2 times, most recently
from
6327aa3 to
bb72d64
Compare
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 56.27% 56.32% +0.05%
==========================================
Files 307 307
Lines 21151 21163 +12
==========================================
+ Hits 11902 11920 +18
+ Misses 8382 8378 -4
+ Partials 867 865 -2 |
albers
reviewed
Mar 19, 2019
Collaborator
albers
left a comment
albers
left a comment
There was a problem hiding this comment.
Completion LGTM. Flag annotation looks odd.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
add_sysctls_for_services
branch
from
bb72d64 to
f620349
Compare
albers
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli changes for moby/moby#37701