Disable docker system dial-stdio on Windows
#1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `conn` here is `*winio.win32MessageBytePipe` which does not have a
`CloseRead` method (it does have `CloseWrite`) resulting in:
docker@WIN-NUC0 C:\Users\docker>.\docker-windows-amd64.exe system dial-stdio
the raw stream connection does not implement halfCloser
Also disable the path which uses this for cli-plugins on Windows.
Signed-off-by: Ian Campbell <[email protected]>
Collaborator
|
According to #1376 it works on Windows with certain configuration? |
Collaborator
|
I think |
Contributor
Author
Ah, I guess there it is a proper tcp socket (which I would guess does indeed support half close in both directions since it is tcp) since it is doing For me (using dial-stdio in a plugin to connect back to the local dameon) it is (I presume) the named pipe, which I suppose doesn't. |
|
/cc @andrey-ko for taking a look at the Windows side of this. |
Contributor
Author
|
@thaJeztah I think this is only tangentially related to plugins (cf the label) |
Contributor
Author
|
#1718 is my attempt to fix this on Windows, PTAL (my testing on Windows has been rather limited) |
ulyssessouza
pushed a commit
to docker-archive-public/docker.app
that referenced
this pull request
Mar 7, 2019
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
chris-crone
pushed a commit
to chris-crone/app
that referenced
this pull request
Mar 7, 2019
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
Contributor
|
Merged, to be reverted when #1718 will land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
connhere is*winio.win32MessageBytePipewhich does not have aCloseReadmethod (it does haveCloseWrite) resulting in:Also disable the path which uses this for cli-plugins on Windows.
Signed-off-by: Ian Campbell [email protected]
/cc @tonistiigi @AkihiroSuda if Windows can't be fixes soon perhaps we should do this and revert when Windows works?