-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Bump Golang 1.12.1 #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Golang 1.12.1 #1708
Conversation
|
Ah, caught some failures; |
|
Ahm.. more to fix; https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1708/2/execution/node/27/log/?consoleFull |
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
=======================================
Coverage 56.23% 56.23%
=======================================
Files 307 307
Lines 21125 21125
=======================================
Hits 11880 11880
Misses 8382 8382
Partials 863 863 |
|
created separate PR's for the fixes;
|
994dd74 to
9c85462
Compare
|
rebased this on top of #1742, so that we can merge that one first (and cherry-pick into the 18.09 release branch) |
go1.12.1 (released 2019/03/14) includes fixes to cgo, the compiler, the go command, and the fmt, net/smtp, os, path/filepath, sync, and text/template packages. See the Go 1.12.1 milestone on our issue tracker for details. For the relase notes of Go 1.12.0, see: https://golang.org/doc/go1.12 Signed-off-by: Sebastiaan van Stijn <[email protected]>
9c85462 to
81b319a
Compare
|
rebased; this should be ready to go now 👍 |
silvin-lubecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Counterpart for the engine is in moby/moby#38404
Making this "WIP" for now, as there's a known regression in Go 1.12.0 that's affecting the engine, so let's wait for 1.12.1 moby/moby#38404 (comment)