Fix potential panic at DockerCli creation #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing the standard error stream instead. Signed-off-by: Silvin Lubecki <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
======================================
Coverage 56.1% 56.1%
======================================
Files 300 300
Lines 20593 20593
======================================
Hits 11554 11554
Misses 8208 8208
Partials 831 831 |
ijc
approved these changes
Jan 29, 2019
Contributor
Author
|
Come on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix using a nil dockerCli if an error occurred during cli creation, using the standard error stream instead.
The code itself wasn't really panicking as
NewDockerClinever returns an error... yet.- A picture of a cute animal (not mandatory but encouraged)
