fixes #46 Always exit 0 when remove image with force option #160
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 45.36% 45.37% +<.01%
==========================================
Files 171 171
Lines 11456 11458 +2
==========================================
+ Hits 5197 5199 +2
Misses 5962 5962
Partials 297 297 |
Signed-off-by: Rogelio Canedo <[email protected]>
Member
|
Hi @e11137, you have to sign your commit for Gordon the Turtle to like you! |
thaJeztah
approved these changes
Jun 13, 2017
| @@ -0,0 +1,2 @@ | |||
| NotFound:image1 | |||
Member
There was a problem hiding this comment.
Was discussing with @vdemeester that the naming of these files is a bit odd; perhaps we should normalise them to be lowercase and have spaces replaced with -. Given that these files are generated, and this is in line with other files in this tests, we can keep it for now 👍
Member
|
@dgageot it was already fixed
|
Member
|
Thank you @e11137 ! |
trapier
pushed a commit
to trapier/cli
that referenced
this pull request
Sep 30, 2019
…-19.03-2f1931f9eb2d6bac2efd48d94739f2e9919d4d7d [19.03] sync to upstream 19.03 2f1931f
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.06.1] bump version to 17.06.1-ce-rc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always exit with 0 if the -f force option is used