policy: replace golang/snappy with klauspost/compress/snappy#3686
Open
thaJeztah wants to merge 1 commit intodocker:masterfrom
Open
policy: replace golang/snappy with klauspost/compress/snappy#3686thaJeztah wants to merge 1 commit intodocker:masterfrom
thaJeztah wants to merge 1 commit intodocker:masterfrom
Conversation
Member
Author
|
This is a bit unfortunate: 
But maybe not a big concern (at least, we know the klauspost/compress module is of good quality, and well maintained) |
thaJeztah
commented
Mar 3, 2026
Comment on lines
+45
to
+48
| // Decode handles the Snappy block format, not the Snappy stream format. | ||
| func Decode(dst, src []byte) ([]byte, error) { | ||
| return s2.Decode(dst, src) | ||
| } |
Member
Author
There was a problem hiding this comment.
As it's a straight wrapper, we COULD choose to skip the intermediate package (and alias s2 as snappy for clarity), but not sure if there'd ever be any compatibility wrappers added here of course 🤔
The golang/snappy implementation has been archived and is no longer maintained. The github.com/klauspost/compress module provides a maintained implementation, which is a drop-in replacement; https://pkg.go.dev/github.com/klauspost/compress/snappy > This is a drop-in replacement for github.com/golang/snappy. Given that we're already depending on that module, we can switch to the maintained implementation. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
rebased, after the other PR was merged 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golang/snappy implementation has been archived and is no longer maintained. The github.com/klauspost/compress module provides a maintained implementation, which is a drop-in replacement; https://pkg.go.dev/github.com/klauspost/compress/snappy
Given that we're already depending on that module, we can switch to the maintained implementation.