Add BUILDKIT_SYNTAX option handling #3385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows building with a remote builder where frontend.dockerfile.v0 enabled = false in the buildkitd yaml file. Note that this change only allows the usage of BUILDKIT_SYNTAX with a custom frontend image, and using the #syntax directive in this case will still fail. Resolves: docker#3077 Signed-off-by: Will Nonnemaker <[email protected]>
Set gateway `source` to the first part of `BUILDKIT_SYNTAX` and `cmdline` to the entire raw value to preserve additional options. Signed-off-by: Dan Duvall <[email protected]>
tonistiigi
approved these changes
Aug 26, 2025
Contributor
Author
|
Thanks, @tonistiigi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the
BUILDKIT_SYNTAXbuild argument directly in buildx instead of relying on thedockerfile.v0frontend to perform forwarding.Derived from #3157 preserving the initial commit from @wnonnemaker and making changes requested by @tonistiigi.