driver: create cdi spec dirs in container builder #3065
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates and closes moby/buildkit#5840
BuildKit image does not have any CDI spec folders created so when running this container we have the following "CDI setup error" warnings:
That means these folders are not monitored and therefore creating a CDI specification will not trigger an auto-refresh of CDI devices.
This is a better approach than moby/buildkit#5840 because we take into account the buildkit configuration to either skip cdi spec dirs creation if feature is disabled but also custom spec dirs set.