Skip to content

don't warn user about missing --allows when running with progress=rawjson #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

don't warn user about missing --allows when running with progress=rawjson #2957

merged 1 commit into from
Feb 8, 2025
+4 −2

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 31, 2025

When ran with rawjson progress mode, client only expect output to contain json messages. warning about missing --allow should then be skipped.

@ndeloof ndeloof requested a review from tonistiigi January 31, 2025 08:05
@crazy-max crazy-max added this to the v0.20.2 milestone Feb 1, 2025
@ndeloof ndeloof mentioned this pull request Feb 5, 2025
Open
tonistiigi
tonistiigi approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also reconfigure logrus logger probably.

@tonistiigi tonistiigi merged commit d557da1 into docker:master Feb 8, 2025
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@crazy-max crazy-max crazy-max approved these changes

Assignees

No one assigned

Labels

area/cli

Projects

None yet

Milestone

v0.20.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ndeloof @tonistiigi @crazy-max