Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max force-pushed the fix-network-attr-yaml branch from c71d551 to 6e3a566 Compare November 14, 2024 18:14
@crazy-max crazy-max changed the title test: bake print compose file bake: check for empty build network with compose Nov 14, 2024
@crazy-max crazy-max added this to the v0.18.1 milestone Nov 14, 2024
@crazy-max crazy-max force-pushed the fix-network-attr-yaml branch from 6e3a566 to 0c07256 Compare November 14, 2024 18:23
@crazy-max crazy-max force-pushed the fix-network-attr-yaml branch from 0c07256 to 4897778 Compare November 14, 2024 18:28
@crazy-max crazy-max requested a review from tonistiigi November 14, 2024 20:53
@crazy-max crazy-max marked this pull request as ready for review November 14, 2024 20:53
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What case is it fixing? Is the issue that compose parser is reusing some of the pointers it returns?

@crazy-max
Copy link
Member Author

What case is it fixing? Is the issue that compose parser is reusing some of the pointers it returns?

This is similar to what we got with hcl in #2689 but this time for compose

@tonistiigi tonistiigi merged commit 3b943bd into docker:master Nov 15, 2024
112 checks passed
@crazy-max crazy-max deleted the fix-network-attr-yaml branch November 15, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants