deps: update buildkit, vendor changes #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
vendor-update
branch
from
9d09bab to
3ee381f
Compare
Collaborator
|
cc @thaJeztah since updates to docker/cli 😄 |
Member
|
Overall looks fine, but before merging, you could consider having a look at moby/buildkit#4523 - if that's merged, you could update moby and docker/cli to v25.0.0-rc.1 The tricky bit is that neither docker/cli nor moby/moby are a module yet, so currently it requires "manual" compare of the vendor.mod from these repositories; one dependency that looks to be "behind" is Cobra; in docker/cli we updated to 1.8. CI looks green so it's not critical, and I'm happy to do a follow-up to align some f the remaining modules. |
Member
|
@jsternberg moby/buildkit#4523 was merged, so you can consider updating to current master 👍 |
Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
vendor-update
branch
from
3ee381f to
ba43fe0
Compare
tonistiigi
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.