Fix for rails getting confused by an empty env var #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Oct 8, 2025
docker-entrypoint.sh
Outdated
| # https://github.com/docker-library/redmine/issues/397 | ||
| # empty string is truthy in ruby and so masks the generated fallback config | ||
| # https://github.com/rails/rails/blob/1aa9987169213ce5ce43c20b2643bc64c235e792/railties/lib/rails/application.rb#L454 | ||
| export SECRET_KEY_BASE |
Member
There was a problem hiding this comment.
Hmm, I think the bug is really closer to missing the unset SECRET_KEY_BASE below when it's empty and we already have a secret_token.rb, right? Maybe we should be more explicit about that half instead of the export half?
Member
|
I pushed another commit, but I'm not convinced I actually like it - the original had simpler logic. |
yosifkit
commented
Oct 8, 2025
docker-entrypoint.sh
Outdated
Comment on lines
159
to
164
| fi | ||
| # generate SECRET_KEY_BASE if not set; this is not recommended unless the secret_token.rb is saved when container is recreated | ||
| if [ -z "$SECRET_KEY_BASE" ] && [ ! -f config/initializers/secret_token.rb ]; then | ||
| # generate SECRET_KEY_BASE in-file if not set; this is not recommended unless the secret_token.rb is saved when container is recreated | ||
| if [ -z "${SECRET_KEY_BASE:-}" ] && [ ! -f config/initializers/secret_token.rb ]; then | ||
| echo >&2 'warning: no *SECRET_KEY_BASE set; running `rake generate_secret_token` to create one in "config/initializers/secret_token.rb"' | ||
| unset SECRET_KEY_BASE # just in case | ||
| rake generate_secret_token | ||
| fi |
Member
Author
There was a problem hiding this comment.
I think I like your change better but maybe we should also combine this second if to be inside the first rather than repeating the condition?
# left out indentation changes
- fi
# generate SECRET_KEY_BASE in-file if not set; this is not recommended unless the secret_token.rb is saved when container is recreated
- if [ -z "${SECRET_KEY_BASE:-}" ] && [ ! -f config/initializers/secret_token.rb ]; then
+ if [ ! -f config/initializers/secret_token.rb ]; then
echo >&2 'warning: no *SECRET_KEY_BASE set; running `rake generate_secret_token` to create one in "config/initializers/secret_token.rb"'
rake generate_secret_token
fi
+ fi
yosifkit
commented
Oct 8, 2025
docker-entrypoint.sh
Outdated
Comment on lines
158
to
159
| unset SECRET_KEY_BASE | ||
| # generate SECRET_KEY_BASE in-file if not set; this is not recommended unless the secret_token.rb is saved when container is recreated |
Member
Author
There was a problem hiding this comment.
The juxtaposition of "unset" followed by "if not set". 😆
Suggested change
| unset SECRET_KEY_BASE | |
| # generate SECRET_KEY_BASE in-file if not set; this is not recommended unless the secret_token.rb is saved when container is recreated | |
| unset SECRET_KEY_BASE | |
| # generate SECRET_KEY_BASE in-file since it is not set or empty; this is not recommended unless the secret_token.rb is saved when container is recreated |
yosifkit
commented
Oct 8, 2025
Member
Author
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Now it's as much your PR as it is mine ❤️🙈, but LGTM.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 8, 2025
Changes: - docker-library/redmine@01d5e42: Fix for rails getting confused by an empty env var (docker-library/redmine#398)
StamatisKourk
pushed a commit
to elastic/official-images
that referenced
this pull request
Nov 11, 2025
Changes: - docker-library/redmine@01d5e42: Fix for rails getting confused by an empty env var (docker-library/redmine#398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397