[19.03] bump swarmkit to f35d9100f2c6ac810cc8d7de6e8f93dcc7a42d29 ENGCORE-1028

[thaJeztah]

full diff: moby/swarmkit@bbe3418...f35d910

changes included:

• [19.03 backport] Remove hardcoded IPAM config subnet value for ingress network moby/swarmkit#2891 [19.03 backport] Remove hardcoded IPAM config subnet value for ingress network
  • backport of Remove hardcoded IPAM config subnet value for ingress network moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network
  • fixes ENGCORE-1028 Specifying --default-addr-pool for docker swarm init is not picked up by ingress network

[thaJeztah]

ping @arkodg @dperny @kolyshkin ptal

[andrewhsu]

LGTM

[thaJeztah]

Looks like this broke CI (quoting @andrewhsu from a comment on an internal ticket)

From the history of PRs merged to the docker/engine 19.03 codeline:
https://ci.docker.com/public/blue/organizations/jenkins/engine/activity?branch=19.03

Looks like the TestServiceWithDefaultAddressPoolInit test started failing when #369 was merged. See error after merge to 19.03:

 --- FAIL: TestServiceWithDefaultAddressPoolInit (1.60s)
     service_test.go:398: Creating a new daemon at: /go/src/github.com/docker/docker/bundles/test-integration/1/TestServiceWithDefaultAddressPoolInit
     daemon.go:321: [d9c735f5b777b] waiting for daemon to start
     daemon.go:339: [d9c735f5b777b] daemon started
     service_test.go:423: TestServiceWithDefaultAddressPoolInit: NetworkInspect: {Name:saanvisthiraTestServiceWithDefaultAddressPoolInit ID:skd85d6326u0vot7xj35e7w06 Created:2019-09-20 01:16:12.558779258 +0000 UTC Scope:swarm Driver:overlay EnableIPv6:false IPAM:{Driver:default Options:map[] Config:[{Subnet:20.20.1.0/24 IPRange: Gateway:20.20.1.1 AuxAddress:map[]}]} Internal:false Attachable:false Ingress:false ConfigFrom:{Network:} ConfigOnly:false Containers:map[] Options:map[com.docker.network.driver.overlay.vxlanid_list:4097] Labels:map[] Peers:[] Services:map[]}
     service_test.go:425: assertion failed: 20.20.1.0/24 (out.IPAM.Config[0].Subnet string) != 20.20.0.0/24 (string)

I did some preparations to fix this;

• rebased Add TC to check dynamic subnet for ingress network moby/moby#39966 to include the swarmkit vendoring so that we can verify if it works
• prepared a cherry-pick of Add TC to check dynamic subnet for ingress network moby/moby#39966 to docker/engine 19.03 ([19.03 backport] Add TC to check dynamic subnet for ingress network #374)
• prepared a revert of ([19.03] bump swarmkit to f35d9100f2c6ac810cc8d7de6e8f93dcc7a42d29 ENGCORE-1028 #369) in case we cannot get the test merged upstream.